Fix repo.json: embed the manifest, don't just list its fields

Read the Homebrew Channel's own DetailsPanel.js: when an app is opened
from Browse, refresh() only ever takes entry.manifest directly, or
fetches entry.manifestUrl if that's absent — never the entry's own
top-level fields. Our repo.json had neither, so
resolveURL(undefined, repositoryURL) threw before the fetch could even
start, and the details screen spun on "Loading" forever with no visible
error. This is what happened when it was tried against a real repo.

Fixed by nesting the full manifest under a "manifest" key per package
entry, alongside the id/title/iconUri the Browse grid reads directly.
Verified structurally (grid fields present, manifest embedded and
non-empty, ipkUrl absolute) since there's no local Homebrew Channel
build to run this against.

Also caught in the same investigation: a stale --base-url in the docs
used the tag v1.0.0 while the actual release was tagged 1.0.0, which
404s the icon and ipk silently — same symptom, different cause. Noted
in both the tool's docstring and the docs that a tag mismatch looks
identical to the manifest bug from the client's side.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

tools/make-manifest.py

@@ -6,15 +6,27 @@ The manifest (out/manifest.json) is one app entry: id, ipkUrl, ipkHash, and so
 on. It is what you submit to webosbrew/apps-repo to get into the official
 store.
 
-The repo index (out/repo.json) is that same entry wrapped as
-`{"packages": [...]}`, which is the format the Homebrew Channel's own
-"Add repository" dialog expects (Settings -> Repositories -> Add repository).
-Host it anywhere static, paste its URL in, and the app shows up in Browse —
-no submission, no review, no shell access to the TV at all.
+The repo index (out/repo.json) is `{"packages": [...]}`, which is the format
+the Homebrew Channel's own "Add repository" dialog expects (Settings ->
+Repositories -> Add repository). Host it anywhere static, paste its URL in,
+and the app shows up in Browse — no submission, no review, no shell access to
+the TV at all.
+
+Each package entry embeds the full manifest under a "manifest" key. That is
+not decoration: the app's details screen (DetailsPanel.refresh(), read
+straight from its source) only ever uses entry.manifest directly, or fetches
+entry.manifestUrl if entry.manifest is absent. Ship a repo.json without either
+one and the details view calls resolveURL(undefined, ...), throws, and spins
+on "Loading" forever with no error shown. Embedding beats a manifestUrl
+because there is only one file to keep in sync.
 
     python3 tools/make-manifest.py \\
         --base-url https://git.example/you/lgtv-audio-cap/releases/download/v1.0.0
 
+--base-url must be the exact release download URL, tag and all — the icon and
+ipk links are absolute, so a tag typo (v1.0.0 vs 1.0.0) 404s silently rather
+than falling back to anything.
+
 Defaults to the newest ipk in out/ and writes out/manifest.json + out/repo.json.
 """
 
@@ -91,9 +103,23 @@ def main():
     print("\nwrote %s" % os.path.relpath(args.out, ROOT), file=sys.stderr)
 
     if args.repo_out:
+        # The grid view (BrowserPanel) reads id/title/iconUri straight off the
+        # package entry. The details view (DetailsPanel) only ever looks at
+        # entry.manifest directly, or fetches entry.manifestUrl if that is
+        # missing — never the entry's own top-level fields. Skipping
+        # manifestUrl (a second file, a second URL to keep in sync) by
+        # embedding the manifest here means DetailsPanel takes its
+        # already-ready fast path and never issues that fetch at all.
+        package_entry = {
+            "id": manifest["id"],
+            "title": manifest["title"],
+            "iconUri": manifest["iconUri"],
+            "shortDescription": manifest["appDescription"],
+            "manifest": manifest,
+        }
         os.makedirs(os.path.dirname(args.repo_out) or ".", exist_ok=True)
         with open(args.repo_out, "w") as fh:
-            json.dump({"packages": [manifest]}, fh, indent=2)
+            json.dump({"packages": [package_entry]}, fh, indent=2)
             fh.write("\n")
         print("wrote %s" % os.path.relpath(args.repo_out, ROOT), file=sys.stderr)